Open
Conversation
Macil
requested changes
Aug 15, 2017
Collaborator
Macil
left a comment
Macil
left a comment
There was a problem hiding this comment.
- Looks like this pull request has test or lint errors.
- Can you add a new test that tests the new functionality?
| }); | ||
| } | ||
|
|
||
| var deferedQueue = []; |
Collaborator
There was a problem hiding this comment.
If multiple browserify runs are happening simultaneously (it doesn't happen when using browserify from the CLI but can be done when using browserify from node), then it looks like they'll all share the same deferedQueue variable which doesn't seem intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handles stream entries that were passed without a backing file and so do not have a modified time by comparing the contents of the steam once browserify has read it. This is especially useful when using browserify-incremental with gulp.